{"json_modified": "2016-03-28T07:56:03.146506", "uuid": "5be98d87-cd01-4536-883f-4ac942f90ef6", "title": "Code Review FAQ", "url": "/en-US/docs/Code_Review_FAQ", "tags": ["Developing Mozilla", "Review"], "translations": [{"uuid": "8b2f8afa-271e-4e4b-914e-72ad40696b5f", "title": "Code Review FAQ", "url": "/ja/docs/Code_Review_FAQ", "tags": ["Developing Mozilla"], "summary": "\u30b3\u30fc\u30c9\u30ec\u30d3\u30e5\u30fc\u306f\u3001\u30d1\u30c3\u30c1\u306e\u8a2d\u8a08\u3068\u5b9f\u88c5\u306b\u3064\u3044\u3066\u691c\u8a3c\u3092\u884c\u3046\u305f\u3081\u306e\u3001\u57fa\u672c\u7684\u306a\u6a5f\u69cb\u3067\u3059\u3002\u6ca2\u5c71\u306e\u30cf\u30c3\u30ab\u30fc\u305f\u3061\u304c Mozilla \u306e\u69d8\u3005\u306a\u30e2\u30b8\u30e5\u30fc\u30eb\u306b\u5bfe\u3057\u3066\u884c\u3046\u8a2d\u8a08\u3068\u5b9f\u88c5\u3092\u3001\u5e38\u306b\u4e00\u8cab\u3057\u305f\u30ec\u30d9\u30eb\u306e\u3082\u306e\u306b\u3059\u308b\u305f\u3081\u306b\u5f79\u7acb\u3063\u3066\u3044\u307e\u3059\u3002\u79c1\u305f\u3061\u306f\u73fe\u5728\u3001\u4e8c\u6bb5\u968e\u306e\u30ec\u30d3\u30e5\u30fc\u3092\u884c\u3063\u3066\u3044\u307e\u3059\u3002\u300c\u30ec\u30d3\u30e5\u30fc\u300d\u3068\u300c\u30b9\u30fc\u30d1\u30fc\u30ec\u30d3\u30e5\u30fc\u300d\u3067\u3059\u3002", "localization_tags": [], "locale": "ja", "last_edit": "2007-11-01T15:09:21", "review_tags": []}], "modified": "2014-03-25T17:45:41", "label": "Code Review FAQ", "localization_tags": [], "locale": "en-US", "id": 3780, "last_edit": "2013-03-14T09:14:50", "summary": "Code review is our basic mechanism for validating the design and implementation of patches. It also helps us maintain a level of consistency in design and implementation practices across the many hackers and among the various modules of Mozilla. We currently have two levels of review, known as \"review\" and \"super-review.\"", "sections": [{"id": "What_is_the_purpose_of_code_review.3F", "title": "What is the purpose of code review?"}, {"id": "Who_must_review_my_code.3F", "title": "Who must review my code?"}, {"id": "What_do_reviewers_look_for.3F", "title": "What do reviewers look for?"}, {"id": "What_is_super-review.3F", "title": "What is super-review?"}, {"id": "Does_a_super-reviewer_need_domain_expertise.3F", "title": "Does a super-reviewer need domain expertise?"}, {"id": "Why_does_the_Super-Reviewer_document_associate_super-reviewers_with_subject_areas.3F", "title": "Why does the Super-Reviewer document associate super-reviewers with subject areas?"}, {"id": "What_if_a_super-reviewer_misses_things.3F", "title": "What if a super-reviewer misses things?"}, {"id": "Do_I_always_need_to_get_a_review_before_a_super-review.3F", "title": "Do I always need to get a review before a super-review?"}, {"id": "How_can_I_tell_the_status_of_reviews_and_super-reviews.3F", "title": "How can I tell the status of reviews and super-reviews?"}, {"id": "How_fast_should_I_get_a_response.3F", "title": "How fast should I get a response?"}, {"id": "What_if_I_don.27t_get_any_answer.3F", "title": "What if I don't get any answer?"}, {"id": "What_is_the_chance_of_getting_an_actual_super-review_within_24_hours.3F", "title": "What is the chance of getting an actual super-review within 24 hours?"}, {"id": "Why_can.27t_I_check_in_now_and_get_super-review_later.3F", "title": "Why can't I check in now and get super-review later?"}, {"id": "What_kind_of_response_might_a_super-reviewer_give.3F", "title": "What kind of response might a super-reviewer give?"}, {"id": "Why_do_I_need_to_wait_for_a_super-reviewer_to_give_a_.22rs.3D.22.3F_Why_can.27t_I_make_the_decision_that_this_is_a_minor_change_not_needing_super-review_myself.3F", "title": "Why do I need to wait for a super-reviewer to give a \"rs=\"? Why can't I make the decision that this is a minor change not needing super-review myself?"}, {"id": "Why_can.27t_a_SR_give_both_an_R_and_a_SR_if_he.27s_the_module_owner.3F", "title": "Why can't a SR give both an R and a SR if he's the module owner?"}, {"id": "What_if_one_or_more_reviewers_say_my_patch_is_low_priority_and_they_won.27t_get_to_it_for_a_while.3F", "title": "What if one or more reviewers say my patch is low priority and they won't get to it for a while?"}, {"id": "Can_the_super-reviewer_ask_me_to_do_something_that_is_not_already_precisely_specified_in_the_bug.3F", "title": "Can the super-reviewer ask me to do something that is not already precisely specified in the bug?"}, {"id": "What_if_the_super-reviewer_asks_for_a_change_that_seems_way_out_of_scope_to_me.2C_like_the_strings_example_above.3F", "title": "What if the super-reviewer asks for a change that seems way out of scope to me, like the strings example above?"}, {"id": "Do_the_Super-Reviewers_look_at_the_User_Interface_.2F_User_Experience_issues_as_well.3F", "title": "Do the Super-Reviewers look at the User Interface / User Experience issues as well?"}, {"id": "What_if_the_SR_requested_changes_that_I_don.27t_understand_or_don.27t_know_how_to_implement.3F", "title": "What if the SR requested changes that I don't understand or don't know how to implement?"}, {"id": "Is_super-review_intended_as_a_training_mechanism.3F", "title": "Is super-review intended as a training mechanism?"}, {"id": "What_if_I_want_to_be_a_super-reviewer.3F", "title": "What if I want to be a super-reviewer?"}, {"id": "Original_Document_Information", "title": "Original Document Information"}], "slug": "Code_Review_FAQ", "review_tags": []}